Skip to content

feat(log event notification): Update event processor version & pass notificationCenter to event processor #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 15, 2019
Merged

feat(log event notification): Update event processor version & pass notificationCenter to event processor #345

merged 6 commits into from
Aug 15, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Aug 14, 2019

Summary

This PR puts together the final pieces to enable the log event notification.

  • The event processor dependency is updated to the latest version, which has support for receiving a notification center and using it to trigger log event notifications
  • Initialization code in Optimizely is updated to pass the notification center to the event processor
  • js-sdk-utils is also updated to the latest version in order to start using that package as the single source of truth for notification types

Test plan

Updated unit tests

Issues

OASIS-4976

@mjc1283 mjc1283 requested review from mikeproeng37 and a team August 14, 2019 22:50
@mjc1283 mjc1283 removed their assignment Aug 14, 2019
@mjc1283 mjc1283 added the WIP label Aug 14, 2019
@mjc1283 mjc1283 self-assigned this Aug 14, 2019
@coveralls
Copy link

coveralls commented Aug 14, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 97.607% when pulling a02f117 on mcarroll/OASIS-4976-finished into ff47244 on master.

mikeproeng37
mikeproeng37 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward changes

@mjc1283 mjc1283 removed the WIP label Aug 15, 2019
@mjc1283 mjc1283 merged commit 748eaca into master Aug 15, 2019
@mjc1283 mjc1283 deleted the mcarroll/OASIS-4976-finished branch August 15, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees

@mjc1283 mjc1283

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37