feat(event processor): Validation and defaults for event processor configuration #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 13, 2019 12:44
mikeproeng37
approved these changes
Aug 16, 2019
| @@ -38,8 +38,6 @@ var FEATURE_VARIABLE_TYPES = enums.FEATURE_VARIABLE_TYPES; | |||
| var DECISION_NOTIFICATION_TYPES = enums.DECISION_NOTIFICATION_TYPES; | |||
| var NOTIFICATION_TYPES = enums.NOTIFICATION_TYPES; | |||
|
|
|||
| var DEFAULT_EVENT_MAX_QUEUE_SIZE = 1; | |||
There was a problem hiding this comment.
Yeah makes sense to move this out into the platform-specific entry-points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds validation and defaults for event batch size and flush interval. There are different defaults for the browser & node entry points:
Node: batch size 10, flush interval 30000
Browser: batch size 10, flush interval 1000
I also added validation that ignores invalid values and uses these defaults.
Test plan
Updated unit tests
Issues
OASIS-5163