feat (event processor/pending events dispatcher): In browser entry point, add event listener for pagehide or unload that calls optimizely.close #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mikeproeng37
approved these changes
Aug 16, 2019
| @@ -125,7 +131,24 @@ module.exports = { | |||
| config.eventFlushInterval = DEFAULT_EVENT_FLUSH_INTERVAL; | |||
| } | |||
|
|
|||
| return new Optimizely(config); | |||
| var optimizely = new Optimizely(config); | |||
There was a problem hiding this comment.
I wonder if we should bother making this turnoffable in case the user is really adamant about doing it themselves. I don't see it as a hard blocker for this PR though. Just food for thought.
There was a problem hiding this comment.
That's a fair question. I think this is the right default given that batching will be enabled by default. I'm willing to wait and see if there's any interest in turning it off from users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With event batching,
optimizely.close()needs to be called to ensure that events are flushed before the user navigates away. This PR ensures that optimizely.close() is called when the page unloads by hooking into thepagehideevent or theunloadevent.Test plan
Added a UMD bundle test. Manually tested.