Skip to content

fix(event processor): Treat eventFlushInterval 0 as invalid #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

fix(event processor): Treat eventFlushInterval 0 as invalid #351

merged 1 commit into from
Aug 20, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Aug 20, 2019

Summary

When 0 is provided for eventFlushInterval, it should be ignored and the default used instead.

Test plan

New unit test

@mjc1283 mjc1283 requested review from mikeproeng37 and a team August 20, 2019 18:31
@mjc1283 mjc1283 removed their assignment Aug 20, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 97.598% when pulling c0be8ae on mcarroll/event-processor-flush-zero-invalid into 1be4665 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 97.598% when pulling c0be8ae on mcarroll/event-processor-flush-zero-invalid into 1be4665 on master.

mikeproeng37
mikeproeng37 approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 88d87dd into master Aug 20, 2019
@mjc1283 mjc1283 deleted the mcarroll/event-processor-flush-zero-invalid branch August 20, 2019 19:30
@code-of-code code-of-code mentioned this pull request Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37