Skip to content

fix(unit tests): Make test assertion for json schema validation failure less specific #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Sep 25, 2019

Summary

A new patch version of json-schema was released that changed an error message. Our test specifically asserts on the old version of the error message.

With this change we assert on a substring that's included in both the old & new versions.

Test plan

Run unit tests

@mjc1283 mjc1283 added the WIP label Sep 25, 2019
@mjc1283 mjc1283 requested a review from a team as a code owner September 25, 2019 18:18
@mjc1283 mjc1283 self-assigned this Sep 25, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.598% when pulling 2858629 on mcarroll/fix-json-schema-test into 0eb3ba3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.598% when pulling 2858629 on mcarroll/fix-json-schema-test into 0eb3ba3 on master.

@mjc1283 mjc1283 removed the WIP label Sep 25, 2019
@mjc1283 mjc1283 removed their assignment Sep 25, 2019
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 1a3f078 into master Sep 25, 2019
@mjc1283 mjc1283 deleted the mcarroll/fix-json-schema-test branch September 25, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants