Skip to content

feat: Updated lint configuration for optimizely-sdk package #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 18, 2019
Merged

feat: Updated lint configuration for optimizely-sdk package #378

merged 5 commits into from
Dec 18, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Dec 17, 2019

Summary

  • Adds a new eslint configuration based on the current recommended rule set
  • Fixes errors and warnings from this updated rule set
  • Add a stage in Travis configuration to enforce lint rules

Test plan

Existing tests

@mjc1283 mjc1283 requested a review from a team as a code owner December 17, 2019 23:37
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.537% when pulling 8d738d6 on mcarroll/lint into d48ede0 on master.

@mjc1283 mjc1283 removed their assignment Dec 18, 2019
mikeproeng37
mikeproeng37 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks for cleaning up!

@mjc1283 mjc1283 merged commit cafd45c into master Dec 18, 2019
@mjc1283 mjc1283 deleted the mcarroll/lint branch December 18, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37