Skip to content

ci(travis): adds awesome_bot for linting *.md files #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2020
Merged

ci(travis): adds awesome_bot for linting *.md files #380

merged 2 commits into from
Jan 2, 2020

Conversation

juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Dec 19, 2019 •
edited
Loading

Summary

  • awesome_bot will check urls in md for broken links and generate report with suggestions
  • moved source clear to run in 'integration tests' stage, we dont need to run source clear again and again in every stage (when declared at the top level)

@juancarlostong juancarlostong requested a review from a team as a code owner December 19, 2019 19:55
@coveralls
Copy link

coveralls commented Dec 19, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.555% when pulling 175dd1e on jctong/lint_md into d61281b on master.

mjc1283
mjc1283 suggested changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a sourceclear-related change in here as well, which should be described.

@juancarlostong juancarlostong merged commit 60af4c5 into master Jan 2, 2020
@juancarlostong juancarlostong deleted the jctong/lint_md branch January 2, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees

@juancarlostong juancarlostong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlostong @coveralls @mjc1283