Skip to content

fix: Remove iphone 6 from browserstack tests #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix: Remove iphone 6 from browserstack tests #386

merged 2 commits into from
Jan 15, 2020

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Jan 15, 2020 •
edited
Loading

Summary

Browserstack has stopped supporting emulators and simulators, causing our cross browser tests to fail when we try to launch them on iphone 6. This removes iphone 6 from our test configuration.

Test plan

Existing tests

@mjc1283 mjc1283 added the WIP label Jan 15, 2020
@mjc1283 mjc1283 self-assigned this Jan 15, 2020
@coveralls
Copy link

coveralls commented Jan 15, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.476% when pulling 761622f on mcarroll/fix-browserstack-tests into 6fa9cd0 on master.

@mjc1283 mjc1283 changed the title test (WIP): Remove iphone 6 from browserstack tests fix: Remove iphone 6 from browserstack tests Jan 15, 2020
@mjc1283 mjc1283 removed the WIP label Jan 15, 2020
@mjc1283 mjc1283 marked this pull request as ready for review January 15, 2020 17:34
@mjc1283 mjc1283 requested a review from a team as a code owner January 15, 2020 17:34
@mjc1283 mjc1283 removed their assignment Jan 15, 2020
mikeproeng37
mikeproeng37 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mjc1283 mjc1283 merged commit 728c7c0 into master Jan 15, 2020
@mjc1283 mjc1283 deleted the mcarroll/fix-browserstack-tests branch January 15, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjc1283 @coveralls @mikeproeng37