Removed dependency on lodash.assign #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Feb 18, 2020
| var applyPolyfills = function() { | ||
| if (typeof Object.assign !== 'function') { | ||
| // Must be writable: true, enumerable: false, configurable: true | ||
| Object.defineProperty(Object, "assign", { |
There was a problem hiding this comment.
We should not mutate global objects. I suggest to compare these 3 options and choose the one that results in smallest bundle size:
- Include this same helper function, but just call it if
Object.assignisn't available, instead of mutating the globalObject. - Use object-assign library from npm (https://www.npmjs.com/package/object-assign)
- Use TypeScript with object spread syntax
There was a problem hiding this comment.
Using typescript for only this looked like an overkill to me. I went for option 1 which will have no implact on the bundle size. I also modified all lodash.assignIn usages to use assign instead because it looks like we are not dealing with inherited properties here.
mjc1283
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to reduce package size, we are trying to gradually get rid of lodash library. This PR replaces
assignfunction withObject.assign. Also added a polyfill method to support old browsers. Polyfill was taken from MDN.https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill
Test Plan
All tests pass after this change.