Skip to content

Removed dependency on lodash.keyBy #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 25, 2020
Merged

Conversation

zashraf1985
Copy link
Contributor

Summary

Replaced lodash values function with keyBy from js-sdk-utils and added missing functionality. This is part of an effort to remove lodash dependency to reduce bundle size.

Test Plan

  1. Added Unit tests
  2. All Unit tests and Full Stack SDK compatibility passed

@zashraf1985 zashraf1985 requested a review from a team as a code owner February 25, 2020 16:45
@zashraf1985 zashraf1985 removed their assignment Feb 25, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 97.567% when pulling 9b2e327 on zeeshan/replace-lodash-keyby-2 into c08435e on master.

@mjc1283 mjc1283 merged commit 037f466 into master Feb 25, 2020
@mikeproeng37 mikeproeng37 deleted the zeeshan/replace-lodash-keyby-2 branch June 4, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants