Updates engines.node stanza to reflect actual requirements #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonkarns Could you merge the latest master from this repo into your branch? Then I can go ahead and merge this. |
|
updated (though my branch was only a day old.) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The version spec in package.json#engines.node is out of date from what is specified in the corresponding READMEs. This updates the package to declare the correct minimum version of node.
While it may seem unimportant, the package.json#engines.node spec is respected by some tools, like nodenv, for node version selection. So this being incorrect can potentially activate the wrong version of node for someone developing locally.