change travis file and request node module #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
added 2 commits
February 7, 2018 10:43
|
build |
mikeproeng37
reviewed
Feb 7, 2018
package.json
Outdated
| @@ -35,7 +35,7 @@ | |||
| "json-schema": "^0.2.3", | |||
| "lodash": "^4.13.1", | |||
| "murmurhash": "0.0.2", | |||
| "request": "~2.81.0", | |||
| "request": "^2.81.0", | |||
There was a problem hiding this comment.
The reason we pinned this in the past is because the authors broke legacy support for node. If you make this change it means that we aren't fixed to a version anymore. The better approach would be to fix it to a version that works in Node 4+, like maybe ~2.83.0 and not let it float because the authors have a history of breaking backwards compatibility with minor version bumps.
mikeproeng37
reviewed
Feb 7, 2018
.travis.yml
Outdated
| - '4' | ||
| - '5' | ||
| - '6' | ||
| - node |
There was a problem hiding this comment.
Can you explicitly add 7 and 8 here? The reason is because node will point to latest, which I think is 9 right now. We can even get rid of 4 and 5, but maybe we can look at the node adoption rates first.
mikeproeng37
suggested changes
Feb 7, 2018
mikeproeng37
added a commit
that referenced
this pull request
Feb 15, 2018
* Consolidate all the Node+JS code into this repo. * Run tests with Karma locally. * Include the dist files for real. * Include lib files and also lib target for node modules. * Use scoped package name. * Fix browser field reference. * Update documentation in the repo. * change umd file name reference in README * change travis file and request node module (#73) * change travis file and request node module * remove previous keys * add Key info in README * requirement changes * Automatically parse datafile when it is JSON (#75) * Fix whitespace (#76) * Update package name to optimizely-sdk-core. * Fix tests and change package name to core. * Make sure to run ALL tests. * Remove min node bundle because of compilation errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.