Skip to content

revert #735 and prep for release 0.9.3 for js-sdk-datafile-manager and 0.9.4 for js-sdk-event-processor #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

zashraf1985
Copy link
Contributor

Summary

React native dependencies were converted from peer to optional in js-sd-datafile-manager version 0.9.2 and js-sdk-event-processor version 0.9.3. After releasing, it appeared that they did not work as expected. This PR reverts back that change which was made in #735 and updates changelog and npm version to make new releases for both the packages.

Test plan

  • Manually tested.
  • All unit tests pass

@zashraf1985 zashraf1985 requested a review from a team as a code owner January 31, 2022 17:26
@zashraf1985 zashraf1985 removed their assignment Jan 31, 2022
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.184% when pulling 743f764 on zeeshan/revert-735-prep-for-releases into 5b651f3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.184% when pulling 743f764 on zeeshan/revert-735-prep-for-releases into 5b651f3 on master.

@zashraf1985 zashraf1985 merged commit 1bc6919 into master Jan 31, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/revert-735-prep-for-releases branch January 31, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants