chore: removed travis yml and added git action support #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
suggested changes
Apr 18, 2022
.github/workflows/javascript.yml
Outdated
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
| crossbrowser_and_umd_unit_tests: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| BROWSER_STACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} |
There was a problem hiding this comment.
rename it to BROWSERSTACK_USERNAME
| runs-on: ubuntu-latest | ||
| env: | ||
| BROWSER_STACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} | ||
| BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} |
.github/workflows/javascript.yml
Outdated
| BROWSER_STACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} | ||
| BROWSER_STACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
update across all checkouts to v3.
.github/workflows/javascript.yml
Outdated
| matrix: | ||
| node: [ '8', '9', '10', '12', '14' ] | ||
| steps: | ||
| - uses: actions/checkout@v2 |
| path-to-lcov: ./packages/optimizely-sdk/coverage/lcov.info | ||
| flag-name: run-${{ matrix.node }} | ||
| # This is a parallel build so need this | ||
| parallel: true |
There was a problem hiding this comment.
what does it mean parallel build?
There was a problem hiding this comment.
we are running unit test on multiple node versions and multiple posts on coveralls are required, thats why we are sending those posts in parallel.
| "cover": "nyc report -r lcov", | ||
| "precoveralls": "npm run cover", | ||
| "coveralls": "< coverage/lcov.info coveralls", | ||
| "coveralls": "nyc --reporter=lcov npm test", |
There was a problem hiding this comment.
why is this removed?
There was a problem hiding this comment.
The previous precoveralls and cover is required to post coveralls from travis but it is not working on git actions so we post using 3rd party git action coverallsapp/github-action@master and is no longer require here.
| if: ${{ github.event_name == 'pull_request' }} | ||
| run: | | ||
| echo "SDK_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV | ||
| echo "TRAVIS_BRANCH=${{ github.head_ref }}" >> $GITHUB_ENV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NOTE:
Please update this, this and this line branch name to master before merging.
Test plan
All tests should pass