feat: Add ODP/ATS VuidManager #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Aug 15, 2022
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
|
This PR remains ready for @zashraf1985 's review as well. |
zashraf1985
suggested changes
Aug 16, 2022
packages/optimizely-sdk/lib/plugins/key_value_cache/browserAsyncStorageCache.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/plugins/key_value_cache/inMemoryAsyncStorageCache.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/plugins/key_value_cache/reactNativeAsyncStorageCache.ts
Outdated
Show resolved
Hide resolved
zashraf1985
reviewed
Aug 17, 2022
|
|
||
| import { VuidManager } from '../lib/plugins/vuid_manager'; | ||
| import PersistentKeyValueCache from '../lib/plugins/key_value_cache/persistentKeyValueCache'; | ||
| import { anyString, anything, instance, mock, resetCalls, verify, when } from 'ts-mockito'; |
# Conflicts: # packages/optimizely-sdk/__mocks__/@react-native-async-storage/async-storage.ts # packages/optimizely-sdk/package-lock.json # packages/optimizely-sdk/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Full Stack client should create and manage a unique device or visitor ID (VUID), persistent and shared between multiple SDK instances.
Test plan
Added new unit test spec files to base package
Issues
OASIS-8412