bug: Remove execution context determination #787
Conversation
|
@zashraf1985 This PR should be merged first before 786. |
# Conflicts: # packages/optimizely-sdk/lib/index.browser.ts # packages/optimizely-sdk/lib/index.react_native.ts
| import { createHttpPollingDatafileManager } from './plugins/datafile_manager/browser_http_polling_datafile_manager'; | ||
| import { EXECUTION_CONTEXT_TYPE } from './utils/enums'; | ||
| import { ExecutionContext } from './utils/execution_context'; | ||
| import { createHttpPollingDatafileManager } from './plugins/datafile_manager/http_polling_datafile_manager'; |
There was a problem hiding this comment.
@zashraf1985 @ozayr-zaviar I'm worried that I may not have merged this correctly.
There was a problem hiding this comment.
I think this should probably be './plugins/datafile_manager/browser_http_polling_datafile_manager' I think
| import { createHttpPollingDatafileManager } from './plugins/datafile_manager/react_native_http_polling_datafile_manager'; | ||
| import { EXECUTION_CONTEXT_TYPE } from './utils/enums'; | ||
| import { ExecutionContext } from './utils/execution_context'; | ||
| import { createHttpPollingDatafileManager } from './plugins/datafile_manager/http_polling_datafile_manager'; |
There was a problem hiding this comment.
This too might not be correct either.
Should it be ./plugins/datafile_manager/react_native_http_polling_datafile_manager or './plugins/datafile_manager/http_polling_datafile_manager'?
There was a problem hiding this comment.
I think this one should be react_native_http_polling_datafile_manager. Grrr. Sorry I messed this merge up.
| if (window) { | ||
| return new BrowserRequestHandler(logger, timeout); | ||
| } else if (process) { | ||
| return new NodeRequestHandler(logger, timeout); | ||
| } else { | ||
| return null as unknown as RequestHandler; |
There was a problem hiding this comment.
This will get removed by #786
There was a problem hiding this comment.
Well the whole file will...
Summary
window=== Browser andprocess=== Node is being used for the new code pathTest plan
Issues