Add release notes for the beta version. #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangjoshuah
suggested changes
Mar 28, 2018
packages/optimizely-sdk/CHANGELOG.MD
Outdated
| ``` | ||
| var enabled = optimizelyClient.isFeatureEnabled(‘my_feature_key’, ‘user_1’, userAttributes); | ||
|
|
||
| // to get all enabled features for the user you can call `getEnabledFeatures` |
There was a problem hiding this comment.
separate this into a separate block.
It is an API in its own right and deserves to be treated as such
wangjoshuah
approved these changes
Mar 28, 2018
| var enabled = optimizelyClient.isFeatureEnabled('my_feature_key', 'user_1', userAttributes); | ||
| ``` | ||
|
|
||
| * You can also get all the enabled features for the user by calling: |
There was a problem hiding this comment.
Discuss return type since it's not clear immediately it will be a list. Hopefully we can also add an HTML link to dev docs or knowledge base in the future.
|
build |
1 similar comment
|
build |
|
Actually gonna ignore the e2e tests since this doesn't even touch the source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.