Skip to content

[FSSDK-9586] update node versions #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

[FSSDK-9586] update node versions #911

merged 1 commit into from
Mar 7, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

Test plan

  • added node 20 to unit test matrix. all tests should pass

Issues

  • FSSDK-9586

@raju-opti raju-opti requested a review from a team as a code owner March 7, 2024 16:41
mikechu-optimizely
mikechu-optimizely approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: I had some test hanging when manual testing npm run test-ci under nvm use 20

@mikechu-optimizely
Copy link
Contributor

Oh good, it finished. 👍 After merge, we probably need to update master branch protection to require 20.

@raju-opti raju-opti merged commit 0788f85 into master Mar 7, 2024
@raju-opti raju-opti deleted the raju/node-version branch March 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raju-opti @mikechu-optimizely