Skip to content

[FSSDK-10935] Refactor log object export #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 3, 2025

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Conversion of log message object to log message variable for size reduction!

Test plan

Existing tests have been modified to fit with the changes.

Issues

@coveralls
Copy link

coveralls commented Dec 11, 2024

Coverage Status

coverage: 84.24% (+0.3%) from 83.955%
when pulling 8a79e92 on junaed/fssdk-10935-refactor-log-export
into 1adcbdb on master.

@junaed-optimizely junaed-optimizely marked this pull request as ready for review December 13, 2024 18:25
@junaed-optimizely junaed-optimizely requested a review from a team as a code owner December 13, 2024 18:25
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments

Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@junaed-optimizely junaed-optimizely merged commit 51e8c1a into master Jan 3, 2025
16 of 19 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10935-refactor-log-export branch January 3, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants