-
Notifications
You must be signed in to change notification settings - Fork 0
Too Many TypeScript errors #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll use a .gitignored copy of `master` for Windsurf's ref
- Add proper request/response type interfaces - Update tsconfig.json with better module resolution - Clean up adapter imports and type usage - Remove redundant CDNSettings imports - Improve CloudflareAdapter type safety
Keep Decision interface in OptimizelyProvider as it's a core Optimizely concept
…pt versions - Removed duplicate JavaScript files that have TypeScript equivalents: - coreLogic.js -> CoreLogic.ts - optimizelyProvider.js -> OptimizelyProvider.ts - userProfileService.js -> UserProfileService.ts - eventListeners.js -> EventListeners.ts - registeredListeners.js -> RegisteredListeners.ts - Updated imports in affected files to use TypeScript versions: - CoreLogic.ts - CloudflareAdapter.ts - index.js
- Created new TypeScript API types in src/types/api.ts - Migrated API handlers to TypeScript: - apiRouter.js -> ApiRouter.ts - handlers/datafile.js -> handlers/Datafile.ts - handlers/flagKeys.js -> handlers/FlagKeys.ts - handlers/sdk.js -> handlers/Sdk.ts - handlers/variationChanges.js -> handlers/VariationChanges.ts - Created handlers/index.ts to export all handlers - Updated index.js to use new TypeScript API router - Removed old JavaScript API files
- Removed 'I' prefix from type names following TypeScript best practices - Converted interfaces to type aliases where appropriate - Updated type exports to use explicit named exports - Updated type documentation to reflect changes - Maintained consistent type naming across the codebase
- Remove unused optlyHelper dependency - Replace helper functions with native JSON methods - Add proper error handling for JSON parsing - Fix parameter reassignment with proper variable scoping - Use TypeScript idiomatic type checking
- Convert regular imports to type imports where appropriate - Rename extractCdnSettings to extractDecisionSettings - Update DefaultSettings export to named export - Fix trailingComma to trailingCommas in biome config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm merging this into
main
which I'll rename tomain-old
and try attempt 3 with a better plan.