Skip to content
This repository was archived by the owner on Sep 28, 2023. It is now read-only.

feat: Add feature key tracking #11

Merged
merged 7 commits into from
Oct 6, 2020
Merged

feat: Add feature key tracking #11

merged 7 commits into from
Oct 6, 2020

Conversation

yavorona
Copy link
Contributor

Summary

  • Add feature key tracking to underline feature keys that are not in datafile.

@yavorona yavorona force-pushed the pnguen/add-feature-key-tracking branch from 51c988e to 08c9f96 Compare August 19, 2020 19:56
thomaszurkan-optimizely
thomaszurkan-optimizely reviewed Aug 27, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Is there anyway, we can add a unit test?

@yavorona yavorona force-pushed the pnguen/add-feature-key-tracking branch 3 times, most recently from ee4f45c to ab4f4f8 Compare September 10, 2020 22:23
@yavorona yavorona force-pushed the pnguen/add-feature-key-tracking branch from ab4f4f8 to fa565e7 Compare September 11, 2020 17:08
@yavorona yavorona force-pushed the pnguen/add-feature-key-tracking branch 2 times, most recently from 653d9d6 to 32b97b5 Compare September 30, 2020 03:29
@yavorona yavorona force-pushed the pnguen/add-feature-key-tracking branch from 32b97b5 to 4a54343 Compare September 30, 2020 03:34
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit ac44b6d into master Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yavorona @thomaszurkan-optimizely