This repository was archived by the owner on Sep 28, 2023. It is now read-only.
feat: Add getAllFeatureVariables to auto-complete #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdfcac5 to
4b5d597
Compare
thomaszurkan-optimizely
suggested changes
Oct 6, 2020
There was a problem hiding this comment.
A few things:
- I am running test (you can debug the project just by running it in debug from vscode and then opening another project you want to test with. The getAllFeatureVariables does not auto-complete on the feature key.
- The getAllFeatureVariables test should be with isFeatureEnabled tests as there is no feature variable.
- Can we add getAllFeatureVariables to the debug dialog as well?
thomaszurkan-optimizely
suggested changes
Oct 6, 2020
src/providers.ts
Outdated
| @@ -30,6 +30,7 @@ export const OP_MODE_JS: vscode.DocumentFilter = { | |||
| }; | |||
|
|
|||
| const REGEX = /.*\.getFeatureVariable\([\'\"][a-zA-Z0-9\_\-]+[\',\"], ?[\'\"]$/ | |||
| const REGEX_A = /.*\.getAllFeatureVariables\([\'\"]$/ | |||
There was a problem hiding this comment.
This shouldn't be here. Is it here for testing?
src/providers.ts
Outdated
| @@ -439,6 +442,9 @@ export function getFeatureRegEx(reg:string): RegExp { | |||
| if (reg == 'getFeatureVariableJSON') { | |||
| return REGEX_J | |||
| } | |||
| if (reg == 'getAllFeatureVariables') { | |||
There was a problem hiding this comment.
the regex is used for the second parameter of feature calls. There is no second parameter on getAllFeatureVariables.
test/test.txt
Outdated
| @@ -10,3 +10,5 @@ something.getFeatureVariableBoolean('someFlagKey', ' | |||
| something.getFeatureVariableBoolean("someFlagKey", " | |||
| something.getFeatureVariableJSON('someFlagKey', ' | |||
| something.getFeatureVariableJSON("someFlagKey", " | |||
| something.getAllFeatureVariables(' | |||
There was a problem hiding this comment.
these tests should be removed.
| @@ -401,6 +402,8 @@ const isFeatureApi = (linePrefix:string): boolean => { | |||
| || linePrefix.endsWith('getFeatureVariableBoolean(\"') | |||
| || linePrefix.endsWith('getFeatureVariableJSON(\'') | |||
| || linePrefix.endsWith('getFeatureVariableJSON(\"') | |||
| || linePrefix.endsWith('getAllFeatureVariables(\'') | |||
There was a problem hiding this comment.
I think this and the tests that you have that are not in test.txt
90389d9 to
f669177
Compare
thomaszurkan-optimizely
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getAllFeatureVariablesto auto-complete