Skip to content

sort enabled feature keys #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2018
Merged

sort enabled feature keys #104

merged 2 commits into from
Mar 12, 2018

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Mar 5, 2018

No description provided.

@optibot
Copy link

optibot commented Mar 5, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Mar 5, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 97.52% when pulling 6fc3d32 on oakbani/sort-enabled-feature-keys into 695ca1c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.52% when pulling 6fc3d32 on oakbani/sort-enabled-feature-keys into 695ca1c on master.

@mikeproeng37
Copy link
Contributor

build

mikeproeng37
mikeproeng37 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellyroach-optimizely
Copy link
Contributor

kellyroach-optimizely commented Mar 12, 2018 •
edited
Loading

E2E TEST PASSED
P.R.#104 branch "oakbani/sort-enabled-feature-keys" was tested the new
E2E test for getEnabledFeatures (fullstack-e2e P.R.#118, python-testapp P.R.#12)
and PASSED.

UNIT TESTS
247/247 PASSED

Examined https://jenkins.dz.optimizely.com/job/fullstack-e2e-pipeline/832/console
The E2E tests which aren't passing on Jenkins are of the new
"test_get_feature_variable-xxx" kind under development by Josh and entirely
independent of this P.R.#104 .

kellyroach-optimizely
kellyroach-optimizely approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@kellyroach-optimizely kellyroach-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@kellyroach-optimizely kellyroach-optimizely merged commit cb28ea4 into master Mar 12, 2018
@aliabbasrizvi aliabbasrizvi deleted the oakbani/sort-enabled-feature-keys branch March 29, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@kellyroach-optimizely kellyroach-optimizely kellyroach-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakbani @optibot @coveralls @mikeproeng37 @kellyroach-optimizely