implements missing validations #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
aliabbasrizvi
suggested changes
Mar 15, 2018
tests/test_optimizely.py
Outdated
|
|
||
| mock_logger.assert_called_once_with(enums.LogLevels.ERROR, enums.Errors.NONE_USER_ID_PARAMETER) | ||
| mock_logger.assert_called_with(enums.LogLevels.ERROR, enums.Errors.INVALID_USER_ID_ERROR) |
There was a problem hiding this comment.
This check only asserts the last call and not both calls. What you can do is assertFalseand check log message and then again do the same thing.
There was a problem hiding this comment.
I think you have taken a similar approach below.
tests/test_optimizely.py
Outdated
| self.optimizely.track('test_event', None, event_tags=4200) | ||
|
|
||
| mock_logging.assert_called_with(enums.LogLevels.ERROR, enums.Errors.INVALID_USER_ID_ERROR) | ||
| self.assertEqual(2, mock_logging.call_count) |
There was a problem hiding this comment.
Similar comment as above.
tests/test_optimizely.py
Outdated
| self.optimizely.get_variation('test_experiment', None, attributes={'test_attribute': 'test_value'}) | ||
|
|
||
| mock_logging.assert_called_with(enums.LogLevels.ERROR, enums.Errors.INVALID_USER_ID_ERROR) | ||
| self.assertEqual(2, mock_logging.call_count) |
There was a problem hiding this comment.
Similar comment as above.
|
Closing this PR as most of the APIs params validation have been addressed in #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.