feat (audience match types): Update audience evaluator and project config for new audience match types #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… oakbani/audience-match-types-project-config
aliabbasrizvi
suggested changes
Nov 15, 2018
optimizely/helpers/condition.py
Outdated
| @@ -174,6 +174,10 @@ def is_finite(self, value): | |||
| # numbers.Integral instead of int to accomodate long integer in python 2 | |||
| return False | |||
|
|
|||
| if isinstance(value, bool): | |||
tests/base.py
Outdated
| { | ||
| 'id': '3988293898', | ||
| 'name': 'substringString', | ||
| 'conditions': '["and", ["or", ["or", ' |
There was a problem hiding this comment.
After recent discussions, conditions will not be stringified but instead object (or list of objects and boolean operators)
There was a problem hiding this comment.
I see. Let me revise it.
… oakbani/audience-match-types-project-config
… oakbani/audience-match-types-project-config
nchilada
approved these changes
Nov 21, 2018
| # Conditions of audiences in typedAudiences are not expected | ||
| # to be string-encoded as they are in audiences. | ||
| for typed_audience in self.typed_audiences: | ||
| typed_audience['conditions'] = json.dumps(typed_audience['conditions']) |
There was a problem hiding this comment.
It's kinda weird that we're calling json.dumps on typedAudiences instead of just calling json.loads on audiences, but it looks like ConditionDecoder is the wrench in the works. Hopefully we can reconsider something like #145 in the future!
There was a problem hiding this comment.
Nit: might be clearer to do this during the initial assignment to self.typedAudiences (currently on line 50) instead of mutating self.typedAudiences later. Not a big deal though
… oakbani/audience-match-types-project-config
… oakbani/audience-match-types-project-config
… oakbani/audience-match-types-project-config
88159da
into
oakbani/audience-match-type-condition-evaluator-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates project config and the audience evaluator to finish the implementation of typed audience evaluation:
falsewhen no attributes were passed)Test Plan