Skip to content

feat(DecisionListener): Adds experiment decision listener. #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2019
Merged

feat(DecisionListener): Adds experiment decision listener. #167

merged 2 commits into from
Mar 28, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Mar 27, 2019 •
edited
Loading

Summary

Implemented DecisionListener in following APIs:

  • activate
  • get_variation

Test plan

Unit tests for DecisionListener

Issues

  • OASIS-4350

@rashidsp rashidsp changed the title Oakbani/decison activate getvar feat(DecisionListener): Adds experiment decision listener. Mar 27, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.708% when pulling d1f88c7 on oakbani/decison-activate-getvar into f772ecc on master.

@rashidsp rashidsp requested a review from a team March 28, 2019 07:31
aliabbasrizvi
aliabbasrizvi approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliabbasrizvi aliabbasrizvi merged commit 44ac6c7 into master Mar 28, 2019
@aliabbasrizvi aliabbasrizvi deleted the oakbani/decison-activate-getvar branch March 28, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @coveralls @aliabbasrizvi @oakbani