-
Notifications
You must be signed in to change notification settings - Fork 36
Merging config manager changes into master #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#trust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse my newness, but Shouldn't line 44 be self.logger = optimizely_logger.adapt_logger(logger or optimizely_logger.NoOpLogger())
Per PR 183
[Unless the logger issue has instead been fixed in another place (but I don't see where).]
Summary
See:
#177
#179
#181