Skip to content

fix: Forwarding Event Processor defaults to default event dispatcher #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2020
Merged

fix: Forwarding Event Processor defaults to default event dispatcher #235

merged 3 commits into from
Jan 24, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jan 23, 2020 •
edited
Loading

Summary

Forwarding Event Processor should default to Default Event Dispatcher when provided None.

Currently, we catch exception with this error:

AttributeError: 'NoneType' object has no attribute 'dispatch_event'

Test plan

  • Added a unit test

Issues

@oakbani oakbani requested a review from a team as a code owner January 23, 2020 06:48
@oakbani oakbani removed their assignment Jan 23, 2020
@coveralls
Copy link

coveralls commented Jan 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.746% when pulling 62fed43 on oakbani/fix-forwarding-event-processor into 2ccae39 on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 876d64b into master Jan 24, 2020
@oakbani oakbani deleted the oakbani/fix-forwarding-event-processor branch January 27, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Assignees
No one assigned
Labels
🤖 8 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakbani @coveralls @thomaszurkan-optimizely @optimizely-codereview-bot