chore :update for 3.6 release #299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
suggested changes
Sep 22, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,15 @@ | |||
| # Optimizely Python SDK Changelog | |||
|
|
|||
| ## 3.6.0-beta | |||
| September 21st, 2020 | |||
There was a problem hiding this comment.
This will need to be updated.
CHANGELOG.md
Outdated
| September 21st, 2020 | ||
|
|
||
| ### New Features: | ||
| * Version targeting using semantic version syntax [#293](https://github.com/optimizely/python-sdk/pull/293) |
There was a problem hiding this comment.
nit. Period after last word in all of these updates. So after syntax, accessor and pypy.
CHANGELOG.md
Outdated
|
|
||
| ### New Features: | ||
| * Version targeting using semantic version syntax [#293](https://github.com/optimizely/python-sdk/pull/293) | ||
| * Datafile accessor [#283](https://github.com/optimizely/python-sdk/pull/283) |
There was a problem hiding this comment.
This is not very descriptive. May be Datafile accessor API to get datafile corresponding to the instance.
optimizely/version.py
Outdated
| @@ -11,5 +11,5 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| version_info = (3, 5, 2) | |||
| version_info = (3, 6, 0) | |||
There was a problem hiding this comment.
This will have to be (3, 6, '0-beta')
| @@ -1,14 +1,14 @@ | |||
| # Optimizely Python SDK Changelog | |||
|
|
|||
| ## 3.6.0-beta | |||
| September 21st, 2020 | |||
| September 22st, 2020 | |||
There was a problem hiding this comment.
22nd ... and now 23rd
|
Closing in favor of: #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary