Skip to content

Removing deprecated warnings #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Conversation

The-inside-man
Copy link
Contributor

Summary

    - assertRaisesRegexp -> assertRaisesRegex
    - assertEquals -> assertEqual
    - isAlive() -> is_alive()
    - Check added to base.py to confirm attribute assertRaisesRegex for backwards compatibility to Python2.7

Test plan

Compatibility Test

The-inside-man and others added 2 commits June 3, 2021 09:46
            - assertRaisesRegexp -> assertRaisesRegex
            - assertEquals -> assertEqual
            - isAlive() -> is_alive()
            - Check added to base.py to confirm attribute assertRaisesRegex for backwards compatibility to Python2.7
@keppel2
Copy link

keppel2 commented Jun 10, 2021

Have you looked into preventing future warnings (lint)?

@The-inside-man
Copy link
Contributor Author

Have you looked into preventing future warnings (lint)?

I was looking at the linter, but I wouldn't want to hide valid warnings. Since these deprecations are based on python and supporting libraries being upgraded the warnings are good in the sense it tells us developers to update our code base, but they shouldn't go untouched for too long. So keeping that in mind I don't want to block future warnings, just address them sooner maybe as they come so we are keeping our code base up to date as frequently as possible. For the most part updating to resolve these warnings are very little work and don't take much time. We just need to be concerned with backwards compatibility.

@keppel2
Copy link

keppel2 commented Jun 10, 2021

Oh, I meant enforce a no-warning policy somehow. It would have to be situational, since some warnings are unavoidable.

@The-inside-man
Copy link
Contributor Author

Oh, I meant enforce a no-warning policy somehow. It would have to be situational, since some warnings are unavoidable.

ahh, ok , I see what you are saying! we can pass the --disable-warnings flag when using pytest or similar when building which would help for those who want to avoid. In the build scripts, this could be added to clean the output moving forward, we would then not see these warnings on the builds in CI. locally we would still see them unless we add that flag and same for anyone else using the SDK.

@coveralls
Copy link

coveralls commented Jun 14, 2021

Coverage Status

Coverage remained the same at 95.871% when pulling 5c64dea on jbrown/testcases-remove-warnings into cdc652e on master.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@The-inside-man The-inside-man changed the title Jbrown/testcases remove warnings Removing deprecated warnings Jun 22, 2021
@The-inside-man The-inside-man merged commit c3b191b into master Jun 22, 2021
@The-inside-man The-inside-man deleted the jbrown/testcases-remove-warnings branch June 22, 2021 19:44
The-inside-man added a commit that referenced this pull request Jun 23, 2021
* [MAINTENANCE] Remove Deprecated warnings during build

            - assertRaisesRegexp -> assertRaisesRegex
            - assertEquals -> assertEqual
            - isAlive() -> is_alive()
            - Check added to base.py to confirm attribute assertRaisesRegex for backwards compatibility to Python2.7

* Updating copyrights to 2021 on touched files.
The-inside-man added a commit that referenced this pull request Jul 15, 2021
* [MAINTENANCE] Remove Deprecated warnings during build

            - assertRaisesRegexp -> assertRaisesRegex
            - assertEquals -> assertEqual
            - isAlive() -> is_alive()
            - Check added to base.py to confirm attribute assertRaisesRegex for backwards compatibility to Python2.7

* Updating copyrights to 2021 on touched files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants