Skip to content

[FSSDK-8478] fix: make client odp methods private #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2023
Merged

[FSSDK-8478] fix: make client odp methods private #416

merged 2 commits into from
Feb 9, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • make fetch_qualified_segments, identify_user, setup_odp private methods in Optimizely

Test plan

existing tests should pass

Ticket

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review February 8, 2023 20:58
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner February 8, 2023 20:58
jaeopt
jaeopt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mat001
Mat001 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit c8c80f0 into master Feb 9, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/make_client_odp_methods_private branch February 9, 2023 00:04
@andrewleap-optimizely andrewleap-optimizely changed the title fix: make client odp methods private [FSSDK-8478] fix: make client odp methods private Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @Mat001 @jaeopt