Skip to content

[FSSDK-8946] fix: make odp event identifiers required #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2023
Merged

[FSSDK-8946] fix: make odp event identifiers required #418

merged 2 commits into from
Feb 27, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Updated send_odp_events to require identifiers and contain at least one key

Test plan

  • updated test_optimizely.py

Ticket

jaeopt
jaeopt approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review February 25, 2023 00:09
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner February 25, 2023 00:09
Mat001
Mat001 requested changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the order, it looks good

Mat001
Mat001 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewleap-optimizely andrewleap-optimizely merged commit f000c6e into master Feb 27, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/fix_odp_event_identifiers branch February 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @Mat001 @jaeopt