Skip to content

Updated event_builder #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2017
Merged

Updated event_builder #63

merged 1 commit into from
Jul 18, 2017

Conversation

mauerbac
Copy link
Contributor

  • Attributes list should always be included
  • Removed revision number

@mauerbac mauerbac requested a review from aliabbasrizvi June 28, 2017 05:47
@optibot
Copy link

optibot commented Jun 28, 2017

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Jun 28, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 97.175% when pulling 4bd46d5 on ma/event_builder_fix into 315275d on master.

@mauerbac mauerbac closed this Jun 30, 2017
@mauerbac mauerbac deleted the ma/event_builder_fix branch June 30, 2017 04:48
@mauerbac mauerbac restored the ma/event_builder_fix branch July 1, 2017 00:02
@mauerbac mauerbac reopened this Jul 1, 2017
@optibot
Copy link

optibot commented Jul 1, 2017

Can one of the admins verify this patch?

@mauerbac
Copy link
Contributor Author

mauerbac commented Jul 1, 2017

Ping @aliabbasrizvi / @delikat . See D16574

@coveralls
Copy link

coveralls commented Jul 1, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 97.175% when pulling 4bd46d5 on ma/event_builder_fix into 315275d on master.

@aliabbasrizvi aliabbasrizvi merged commit 138cb0d into master Jul 18, 2017
@aliabbasrizvi aliabbasrizvi deleted the ma/event_builder_fix branch July 18, 2017 05:15
alda-optimizely pushed a commit that referenced this pull request Oct 6, 2017
@mauerbac @alda-optimizely
attributes list should always be in event object. removed revision (#63)
8986141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauerbac @optibot @coveralls @aliabbasrizvi