-
Notifications
You must be signed in to change notification settings - Fork 36
Alda/numeric metrics #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event value to revenue value to better describe its reference.
…eration are valid when only revenue or numeric metric event tags are provided.
…stic way, which made some unit tests inconsistent. Event tag keys is a short list, so the sort should not create overhead.
… event object checks to parameters related to event tags so that the unit tests won't be brittle.
…mbers are supported; everything else should return None.
…t it in the event builder.
Can one of the admins verify this patch? |
build |
build |
mikeproeng37
approved these changes
Sep 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alda-optimizely
added a commit
that referenced
this pull request
Oct 6, 2017
* Added a helper method to find numeric metric values in the event tags. * Added tests for the numeric metric value helper method. * Renamed REVENUE_METRIC_TYPE enum to EVENT_VALUE_METRIC to be consistent with Java. * Replaced hard-coded revenue tag with enum. Renamed the local variable event value to revenue value to better describe its reference. * Added a check for numeric metric value in the event builder. * Fixed unit tests for numeric metric. * Changed event value test names to event tags. Updated test comment descriptions. * Added a couple more unit tests to test track and conversion event generation are valid when only revenue or numeric metric event tags are provided. * Fixed lint errors. * Enabled max diff to see unit test error on travis. * Fixed nit spacing and wording. * Sort the event tag keys as they were being returned in an undeterministic way, which made some unit tests inconsistent. Event tag keys is a short list, so the sort should not create overhead. * Refactored numeric metric unit tests to use a subroutine and isolated event object checks to parameters related to event tags so that the unit tests won't be brittle. * Handled corner cases for the get numeric value better. Strings and numbers are supported; everything else should return None. * Sorted the event features results in the test so we don't have to sort it in the event builder. * Fixed an import statement. * Removed basestring as this is not supported by Python3. * Updated some code comments. * Cleaned up some wording and unit test ordering. * Removed blank line at end of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.