Skip to content

Event Tag Utils Tests Edit #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2017
Merged

Event Tag Utils Tests Edit #80

merged 4 commits into from
Oct 26, 2017

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Sep 28, 2017

✏️ Fixed event tag utils tests

@optibot
Copy link

optibot commented Sep 28, 2017

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Sep 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 96.765% when pulling 1c47e27 on oakbani:task1 into dcef2eb on optimizely:master.

alda-optimizely
alda-optimizely approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@alda-optimizely alda-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Oct 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 96.898% when pulling e1699e4 on oakbani:task1 into 750a4fb on optimizely:master.

@mikeproeng37
Copy link
Contributor

Tests passed. Gonna merge this in.

@mikeproeng37 mikeproeng37 merged commit ebb0ad7 into optimizely:master Oct 26, 2017
@oakbani oakbani deleted the task1 branch October 27, 2017 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alda-optimizely alda-optimizely alda-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakbani @optibot @coveralls @mikeproeng37 @alda-optimizely