Skip to content

Upgrade to V3 endpoint #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2017
Merged

Upgrade to V3 endpoint #81

merged 3 commits into from
Oct 3, 2017

Conversation

mauerbac
Copy link
Contributor

@mauerbac mauerbac commented Oct 3, 2017

cc @mikeng13

@optibot
Copy link

optibot commented Oct 3, 2017

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 95.821% when pulling 0277ca1 on mauerbac/v3-endpoint into dcef2eb on master.

@mauerbac mauerbac requested a review from mikeproeng37 October 3, 2017 19:33
@mikeproeng37
Copy link
Contributor

build

mikeproeng37
mikeproeng37 approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mauerbac mauerbac merged commit 9f80f46 into master Oct 3, 2017
@mauerbac
Copy link
Contributor Author

mauerbac commented Oct 3, 2017

fyi @alda-optimizely - this is ready for you to deploy

alda-optimizely pushed a commit that referenced this pull request Oct 6, 2017
@mauerbac @alda-optimizely
Upgrade to V3 endpoint (#81)
ebcb9e0 
* upgrade to v3 endpoint

* remove print statements

* changed to EventBuilder (removed V3) , use version._version_ in tests
@aliabbasrizvi aliabbasrizvi deleted the mauerbac/v3-endpoint branch October 9, 2017 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauerbac @optibot @coveralls @mikeproeng37