Skip to content

Preventing events from being sent when user is part of a rollout #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2017
Merged

Preventing events from being sent when user is part of a rollout #85

merged 4 commits into from
Oct 12, 2017

Conversation

aliabbasrizvi
Copy link
Contributor

@optimizely/fullstack-devs

mikeproeng37
mikeproeng37 approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Oct 11, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 95.833% when pulling bde3274 on arizvi/no_event_rollout into 9f80f46 on master.

@coveralls
Copy link

coveralls commented Oct 12, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 95.869% when pulling 415314d on arizvi/no_event_rollout into db4a9a6 on master.

@aliabbasrizvi aliabbasrizvi merged commit c2a8349 into master Oct 12, 2017
@aliabbasrizvi aliabbasrizvi deleted the arizvi/no_event_rollout branch October 12, 2017 16:45
aliabbasrizvi added a commit that referenced this pull request Dec 19, 2017
@aliabbasrizvi
Revert "Preventing events from being sent when user is part of a roll…
939cabe 
…out (#85)"

This reverts commit c2a8349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@wangjoshuah wangjoshuah Awaiting requested review from wangjoshuah

@alda-optimizely alda-optimizely Awaiting requested review from alda-optimizely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @mikeproeng37