Skip to content

Introducing feature variable accessors #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2017
Merged

Introducing feature variable accessors #86

merged 5 commits into from
Oct 12, 2017

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

@aliabbasrizvi aliabbasrizvi requested review from mikeproeng37 and a team October 11, 2017 20:16
@coveralls
Copy link

coveralls commented Oct 11, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.857% when pulling 69a0440 on arizvi/variable_accessor into 9f80f46 on master.

mikeproeng37
mikeproeng37 approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangjoshuah
Copy link
Contributor

e2e failed on results API. i just restarted them.

@aliabbasrizvi aliabbasrizvi merged commit db4a9a6 into master Oct 12, 2017
@aliabbasrizvi aliabbasrizvi deleted the arizvi/variable_accessor branch October 12, 2017 16:03
aliabbasrizvi added a commit that referenced this pull request Dec 19, 2017
@aliabbasrizvi
Revert "Introducing feature variable accessors (#86)"
0b2f019 
This reverts commit db4a9a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliabbasrizvi @coveralls @wangjoshuah @mikeproeng37