Skip to content

validate parameters in feature APIs #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 19, 2018
Merged

validate parameters in feature APIs #98

merged 12 commits into from
Jan 19, 2018

Conversation

wangjoshuah
Copy link
Contributor

No description provided.

@wangjoshuah wangjoshuah requested review from mikeproeng37, aliabbasrizvi and a team January 10, 2018 22:42
@optibot
Copy link

optibot commented Jan 10, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Jan 10, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 96.726% when pulling 9c48cdd on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

aliabbasrizvi
aliabbasrizvi previously requested changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off on this for now and talk offline about this.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 96.221% when pulling 7656fc7 on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 96.221% when pulling 7656fc7 on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 96.749% when pulling fa2bcfe on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 97.1% when pulling e095395 on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

@wangjoshuah
Copy link
Contributor Author

build

@coveralls
Copy link

coveralls commented Jan 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 97.1% when pulling 77d9bf3 on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.1% when pulling ef0c0ee on josh.wang/validate_parameters_in_feature_params into 1d882da on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangjoshuah wangjoshuah merged commit fef6401 into master Jan 19, 2018
@wangjoshuah wangjoshuah deleted the josh.wang/validate_parameters_in_feature_params branch January 19, 2018 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@aliabbasrizvi aliabbasrizvi aliabbasrizvi left review comments

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangjoshuah @optibot @coveralls @aliabbasrizvi @thomaszurkan-optimizely