Skip to content

feat(notification-center): Add LogEvent notification #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 44 commits into from
Closed

feat(notification-center): Add LogEvent notification #196

wants to merge 44 commits into from

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Aug 20, 2019 •
edited
Loading

Summary

  • Introduced LogEvent notification in notification_center.rb.
  • Integrated it in batch_event_dispatcher.rb and forwarding_event_processor.rb.
  • Added notification_count in notification_center.rb and integrated into Optimizely for notification types ACTIVATE and TRACK.

Test plan

  • Added unit tests for LogEvent in notification_center_spec.rb, batch_event_dispatcher_spec.rb and forwarding_event_processor_spec.rb.
  • Updated Optimizely's unit tests for LogEvent and notification_count.

rashidsp and others added 30 commits August 1, 2019 16:56
@rashidsp
feat(eventProcessor): Adds EventProcessor and BatchEventProcessor
28ea204
@rashidsp
feat(forwarding-EP): Implements forwarding event processor
bcfca16
@rashidsp
feat(notification-center): Adds LogEvent notification
ccbea99
@rashidsp
log event in forward-EP
f7a5b97
@rashidsp
Addressing feedback
f5db35b
@rashidsp
Addressing feedback
32a566e
@rashidsp
Addressing feedback
c8ed3f7
@rashidsp
fixes log event issue
c0946ea
@rashidsp
Addresses review
cfcf5a8
@rashidsp
resolves test issue
717adb0
@rashidsp
fixes logger issue
6eec6bd
@rashidsp
feat(eventprocess): Integrate Event Processor with Optimizely
7ac5896
@rashidsp
fixes: failing test
899f3a6
@rashidsp
tests: adds SizedQueue
a31a9da
@rashidsp
resolves conflicts
93562a1
@rashidsp
resolves conflicts
0b7e53d
@rashidsp
Merge branch 'rashid/log-event' into rashid/optly-EP-integration
e1f6715
@rashidsp
Merge branch 'master' into rashid/batch-event-processor
309ee3a
@rashidsp
Addresses feedback
096ae95
@rashidsp
Addresses feedback
1341177
@rashidsp
reverts log-event changes
ededaa7
@rashidsp
resolves conflicts
2512412
@rashidsp
config manager update
61e3426
@msohailhussain
Removed verbose log.
b409edf
@rashidsp
Merge branch 'master' into rashid/batch-event-processor
9c019c7
@rashidsp
Resolves unit test
2fd378f
@rashidsp
removes log
efab9f4
@rashidsp
adds positive number conditions
3c4a980
@rashidsp
resolves commits
29fc092
@rashidsp
feat(notification-center): Adds LogEvent notification
6634c54
@rashidsp rashidsp added the WIP Work in progress label Aug 20, 2019
@rashidsp rashidsp requested a review from a team as a code owner August 20, 2019 07:45
@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 99.442% when pulling ecf2d6e on rashid/Batch-EP-logEvent into 2df63ad on master.

@rashidsp rashidsp mentioned this pull request Aug 27, 2019
Merged
@rashidsp rashidsp removed the WIP Work in progress label Aug 28, 2019
@rashidsp rashidsp changed the title feat(notification-center): Add LogEvent notification- WIP feat(notification-center): Add LogEvent notification Aug 28, 2019
@rashidsp rashidsp changed the base branch from rashid/optly-EP-integration to master August 29, 2019 09:52
@msohailhussain
Copy link
Contributor

@rashidsp there are so many commits in this PR which are irrelevant, can you please create a new PR with only single commit?

@rashidsp
Copy link
Contributor Author

Created clean PR: #197
Therefore closing it.

@rashidsp rashidsp closed this Aug 29, 2019
@rashidsp rashidsp deleted the rashid/Batch-EP-logEvent branch August 29, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees

@rashidsp rashidsp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashidsp @coveralls @msohailhussain