Skip to content

fix: Event processor fixes and updated config-manager polling interval #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2019
Merged

fix: Event processor fixes and updated config-manager polling interval #200

merged 5 commits into from
Sep 9, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Sep 5, 2019 •
edited
Loading

Summary

  • Set default Event Dispatcher In case of nil.
  • Log message for flush_interval validation.
  • Flush pending events when stop is called.
  • HTTPProjectConfigManager updates polling_interval validation.

Test plan

  • Added/updated unit tests.

Issues

  • No issue filed.

@rashidsp rashidsp requested a review from a team as a code owner September 5, 2019 10:13
@coveralls
Copy link

coveralls commented Sep 5, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 99.465% when pulling 49d3e6e on rashid/ep-fixes into a34512a on master.

@rashidsp rashidsp mentioned this pull request Sep 5, 2019
Merged
@rashidsp rashidsp changed the base branch from master to rashid/Batch-EP-add-logEvent September 5, 2019 11:36
@rashidsp rashidsp changed the base branch from rashid/Batch-EP-add-logEvent to master September 5, 2019 11:55
@mjc1283 mjc1283 mentioned this pull request Sep 5, 2019
Merged
@rashidsp rashidsp changed the title fix(EP): Event processor fixes fix: Event processor fixes and updated config-manager polling interval Sep 6, 2019
@msohailhussain
Copy link
Contributor

@rashidsp Please update readme. valid duration is great than 0 and less than whatever maximum value is.

@rashidsp rashidsp requested a review from mjc1283 September 6, 2019 17:50
msohailhussain
msohailhussain approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjc1283 mjc1283 merged commit 31e93c7 into master Sep 9, 2019
@mjc1283 mjc1283 deleted the rashid/ep-fixes branch September 9, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@rashidsp rashidsp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @coveralls @msohailhussain @mjc1283