Place Optimizely::Project in optimizely/project.rb
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove requires from project.rb which aren't referenced. Add missing requires to project.rb which _are_ referenced. Remove requires from optimizely.rb which aren't referenced, but are already required by project.rb.
|
@jasonkarns This looks good, would you mind doing a rebase/remerge if it's not too much trouble and we can approve (assuming our tests pass) |
|
too much drift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Classes and modules should be defined in files that correspond to their name. This ensures that developers will know the right place to look because things will be in their conventional location.