Skip to content

Rloomba/add proxy config (#262) #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jul 8, 2020

This branch is a copy of https://github.com/rloomba/ruby-sdk/tree/rloomba/add-proxy-config. I simply moved it into a branch off of master from a fork to go through proper testing.

  • add ability to use http proxy when making web requests

  • fix: linting

  • ignore spellcheck

  • headers and missing test

  • update to use master mdspell

Co-authored-by: Ryan Loomba ryan@loomba.io
Co-authored-by: Owais Akbani owais.akbani92@gmail.com

Summary

  • Allow proxy to be passed into http config manager.

Test plan

Issues

* add ability to use http proxy when making web requests

* fix: linting

* ignore spellcheck

* headers and missing test

* update to use master mdspell

Co-authored-by: Ryan Loomba <ryan@loomba.io>
Co-authored-by: Owais Akbani <owais.akbani92@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.568% when pulling 5a18ac0 on mergeFork into 6ea2681 on master.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely
Copy link
Contributor Author

This is a copy of PR #242. Just needed to update something and this was the quickest way to run through FSC tests. Author is actually @rloomba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants