Skip to content

chore: prepare for 3.9.0 release. #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2021
Merged

chore: prepare for 3.9.0 release. #286

merged 3 commits into from
Sep 16, 2021

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • prepare for release 3.9.0

@coveralls
Copy link

coveralls commented Sep 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.486% when pulling a123203 on uzair/release-ready-3.9.0 into 3a30a00 on master.

@zashraf1985 zashraf1985 changed the title chore: preparing 3.9.0 release. chore: prepare for 3.9.0 release. Sep 16, 2021
@zashraf1985 zashraf1985 marked this pull request as ready for review September 16, 2021 17:09
@zashraf1985 zashraf1985 requested a review from a team as a code owner September 16, 2021 17:09
The-inside-man
The-inside-man approved these changes Sep 16, 2021
View reviewed changes
Copy link

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits

@zashraf1985 @jaeopt
Apply suggestions from code review
a123203 
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
@zashraf1985 zashraf1985 merged commit a49bc5b into master Sep 16, 2021
@zashraf1985 zashraf1985 deleted the uzair/release-ready-3.9.0 branch September 16, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@The-inside-man The-inside-man The-inside-man approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ozayr-zaviar @coveralls @The-inside-man @jaeopt @zashraf1985