feat: add lru cache #306
feat: add lru cache #306
Conversation
| return nil if old_element.stale?(@timeout) | ||
|
|
||
| element = CacheElement.new(old_element.value) | ||
| @map[key] = element |
There was a problem hiding this comment.
It looks like ruby hash keeps insertion order for 1.9+. Min ruby version we support?
There was a problem hiding this comment.
That's one of the main reasons I pushed for updating the minimum supported ruby version. As of 4.0.0, we now only support >=2.7
There was a problem hiding this comment.
@andrewleap-optimizely That min version info should be in README.md file and our docs. Updated?
There was a problem hiding this comment.
The minimum version is listed on the rubygems page but yea we should add it to the readme as well. Looks like a lot of the sdks are missing that information on their readme/docs, may be worth discussing.
lib/optimizely/odp/lru_cache.rb
Outdated
| @map.delete(key) | ||
| return nil if old_element.stale?(@timeout) | ||
|
|
||
| element = CacheElement.new(old_element.value) |
There was a problem hiding this comment.
Timestamp is not supposed to change for lookup. This new creation will overwrite the old timestamp.
There was a problem hiding this comment.
good catch. Fixed and added test to confirm.
Summary
Add a generic LRU cache to support efficient caching of the ODP segments results.
Test plan
Added:
Ticket:
OASIS-8435