Skip to content

fix: Fixed audience segment fetch logic #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: Fixed audience segment fetch logic #320

merged 2 commits into from
Dec 19, 2022

Conversation

ozayr-zaviar
Copy link
Contributor

@ozayr-zaviar ozayr-zaviar commented Nov 30, 2022 •
edited
Loading

Summary

  • Fixed segments fetching from audiences.

Test plan

  • All unit tests and FSC tests should pass.

Ticket

FSSDK-8530

@ozayr-zaviar ozayr-zaviar reopened this Dec 1, 2022
@ozayr-zaviar ozayr-zaviar changed the title fixed audience segment fetch logic fix: Fixed audience segment fetch logic Dec 7, 2022
@msohailhussain msohailhussain marked this pull request as ready for review December 16, 2022 06:20
@msohailhussain msohailhussain requested a review from a team as a code owner December 16, 2022 06:20
jaeopt
jaeopt approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewleap-optimizely
andrewleap-optimizely approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit d999d72 into master Dec 19, 2022
@msohailhussain msohailhussain deleted the uzair/fix-audience-segment branch December 19, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees

@ozayr-zaviar ozayr-zaviar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozayr-zaviar @jaeopt @andrewleap-optimizely @msohailhussain