Skip to content

fix: non_block arg #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix: non_block arg #331

merged 1 commit into from
Apr 4, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Switch non_block arg from keyword to positional

Test plan

all tests pass

@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner April 4, 2023 19:34
jaeopt
jaeopt approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit c447d8e into master Apr 4, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/fix_non_block_arg branch April 4, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @Mat001 @jaeopt