Skip to content

[FSSDK-7825] fix errant test logging #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

Changed DatafileProjectConfig.create to use the provided logger in case of error.

  • Existing functionality assumed there was no valid logger. This method is always called after logger has been validated.
  • If the user has provided a logger, the expectation is that the logger will be used for all logging.

Test plan

all tests pass

Ticket

FSSDK-7825

Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andrewleap-optimizely andrewleap-optimizely merged commit 0cb4940 into master Apr 13, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/fix_errant_test_logging branch April 13, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants