Skip to content

Parse numeric float/string as integer and add logger #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2018
Merged

Parse numeric float/string as integer and add logger #90

merged 1 commit into from
Feb 27, 2018

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Feb 27, 2018

@oakbani
Add logger to Event tag util
df5b1cc 
Parse revenue value
@optibot
Copy link

optibot commented Feb 27, 2018

Can one of the admins verify this patch?

@oakbani oakbani requested a review from mikeproeng37 February 27, 2018 12:49
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 99.648% when pulling df5b1cc on oakbani/revenue-value-logger into 0c7f990 on master.

@mikeproeng37
Copy link
Contributor

build

mikeproeng37
mikeproeng37 approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 2d0cc98 into master Feb 27, 2018
@mikeproeng37 mikeproeng37 deleted the oakbani/revenue-value-logger branch June 27, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakbani @optibot @coveralls @mikeproeng37