Skip to content

Handle SMALLINT and FLOAT oracle db types #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sashabaranov opened this issue Mar 10, 2017 · 5 comments
Closed

Handle SMALLINT and FLOAT oracle db types #4

sashabaranov opened this issue Mar 10, 2017 · 5 comments

Comments

@sashabaranov
Copy link

sashabaranov commented Mar 10, 2017 •
edited
Loading

cx_Oracle 5.x does not handle SMALLINT and FLOAT db types. I am unsure about v6, but fix for 5.x is in #3
@anthony-tuininga
Copy link
Member

Thanks. Can you provide a test case that doesn't work before your patch but does afterwards? Thanks.

@sashabaranov
Copy link
Author

Sorry, I cant really reproduce this now, but basically I've experienced inability to query SMALLINT and FLOAT columns via SQLAlchemy and this fix helped.

anthony-tuininga added a commit to oracle/odpi that referenced this issue Apr 5, 2017
@anthony-tuininga
Added support for smallint and float data types in Oracle objects, as…
8b32091 
… requested

(oracle/python-cx_Oracle#4).
anthony-tuininga added a commit that referenced this issue Apr 5, 2017
@anthony-tuininga
Added support for smallint and float data types in Oracle objects, as…
7f70d18 
… requested

(#4).
anthony-tuininga added a commit that referenced this issue Apr 5, 2017
@anthony-tuininga
Added support for smallint and float data types in Oracle objects, as…
543b22f 
… requested

(#4).
@anthony-tuininga
Copy link
Member

Both 5.x and 6.x patches have now been applied.

anthony-tuininga added a commit that referenced this issue Apr 11, 2017
@anthony-tuininga
Added support for smallint and float data types in Oracle objects, as…
0b01d96 
… requested

(#4).
anthony-tuininga added a commit that referenced this issue Apr 11, 2017
@anthony-tuininga
Added support for smallint and float data types in Oracle objects, as…
243f81f 
… requested

(#4).
@sashabaranov
Copy link
Author

I'm still getting error message cx_Oracle.NotSupportedError: Object_ConvertToPython(): unhandled data type 246 from branch v5.x

@anthony-tuininga
Copy link
Member

That seems rather strange. The test suite was updated to include smallint and float types and it passes. Please make sure that you are running the updated code!

@anthony-tuininga anthony-tuininga mentioned this issue Aug 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sashabaranov @anthony-tuininga